redundant configmap patch operations

[jdef]

kube-mgmt/pkg/configmap/configmap.go

Line 250 in 191879e

patch := map[string]interface{}{

there appears to be no check on the configmap annotations here, to only issue a PATCH to apiserver if the desired value is different than the current. i started investigating this because our OPA policies rarely change, yet I see PATCH requests constantly issued to apiserver. this appears to, perhaps, be part of the problem.

[tsandall]

I suppose kube-mgmt could perform a bytes.Equal check on the configmap data. That said, what's the actual problem you're observing? Those updates are only sent when there's a watch even on the configmaps. Either something on the configmaps is changing or k8s is just firing spurious watch events...

[jdef]

"updates are only sent when there's a watch event..."

AFAICT there's a full resync that happens every minute:

kube-mgmt/pkg/configmap/configmap.go

Line 146 in 191879e

time.Second*60,

.. which corresponds to the audit logs in my cluster; and the update is hitting the apiserver, even when there are no configmap changes.

[jdef]

from the cache API docs re: informers:

resyncPeriod: if non-zero, will re-list this often (you will get OnUpdate
  calls, even if nothing changed). Otherwise, re-list will be delayed as
  long as possible (until the upstream source closes the watch or times out,
  or you stop the controller).

[tsandall]

ah, @jdef you're right...sorry, it's been a while since I've looked at this code.

Feel free to submit a patch if you like.

[jdef]

I would, but I already have a stack of aging (~1yr) OSS patches that have yet to clear our legal department. As much as I'd like to patch this myself in OPA upstream, I'm afraid that I'll be unable to do so until corporate red tape has cleared. I would be grateful if someone in the OPA community could spend 15m on this - thanks!

…

On Tue, Mar 16, 2021 at 8:57 AM Torin Sandall ***@***.***> wrote: ah, @jdef <https://github.com/jdef> you're right...sorry, it's been a while since I've looked at this code. Feel free to submit a patch if you like. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5KLB537GCWK7J5IDG24TTD5IT3ANCNFSM4ZEJIXHA> .

-- James DeFelice 585.241.9488 (voice) 650.649.6071 (fax)

[jdef]

/cc @pires

[jdef]

Was this resolved by a PR? If so, mind linking to it?

…

On Sat, May 7, 2022, 1:13 AM Ievgenii Shepeliuk ***@***.***> wrote: Closed #90 <#90>. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5KLG3A35A7NBXM3WCJJ3VIX3WXANCNFSM4ZEJIXHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[eshepelyuk]

Was this resolved by a PR? If so, mind linking to it?
…
On Sat, May 7, 2022, 1:13 AM Ievgenii Shepeliuk @.> wrote: Closed #90 <#90>. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR5KLG3A35A7NBXM3WCJJ3VIX3WXANCNFSM4ZEJIXHA . You are receiving this because you were mentioned.Message ID: @.>

The links are just above your comment.

[jdef]

Heh, thanks. Was looking at the email thread. Should have checked GH directly On Sat, May 7, 2022, 10:52 AM Ievgenii Shepeliuk ***@***.***> wrote:

…

Was this resolved by a PR? If so, mind linking to it? … <#m_9087902201560492211_> On Sat, May 7, 2022, 1:13 AM Ievgenii Shepeliuk *@*.*> wrote: Closed #90 <#90> <#90 <#90>>. — Reply to this email directly, view it on GitHub <#90 (comment) <#90 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR5KLG3A35A7NBXM3WCJJ3VIX3WXANCNFSM4ZEJIXHA <https://github.com/notifications/unsubscribe-auth/AAR5KLG3A35A7NBXM3WCJJ3VIX3WXANCNFSM4ZEJIXHA> . You are receiving this because you were mentioned.Message ID: @.*> The links are just above your comment. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5KLFNW7ZOJMTAPHXZSE3VIZ7TBANCNFSM4ZEJIXHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>