-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base CI w/ PR checks #13
Comments
What CI tool would you think best fit this? |
I think most of the OPA projects are migrating to use GitHub actions, so we might as well too |
Any reason for github actions vs circleci? |
Mostly just to keep the number of services/tools lower for the https://github.com/open-policy-agent org. If there was some technical reason to pick one over the other I think we're all open to discussing it. I think the assumption is that everything we want to do can be done with any of the usual suspects (travis, circleci, github actions, etc), so with that in mind we are just trying to get projects all onto the same one. |
Okay perfect. Just wrapping my head around all the projects for opa. I have
a better understanding and will probably look at github actions when I have
some time.
…On Thu, 21 May 2020, 19:13 Patrick East, ***@***.***> wrote:
Any reason for github actions vs circleci?
Mostly just to keep the number of services/tools lower for the
https://github.com/open-policy-agent org.
If there was some technical reason to pick one over the other I think
we're all open to discussing it. I think the assumption is that everything
we want to do can be done with any of the usual suspects (travis, circleci,
github actions, etc), so with that in mind we are just trying to get
projects all onto the same one.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOP2H7AHTYD4S5GLFCR3EFDRSVOM7ANCNFSM4M76CXIQ>
.
|
We've got a few things here now, at least some basic CI: #21 brought in e2e.sh; so we're building an running something for PRs. There're no linting/code checks, afaict, yet, though. |
...using deno, because it's easy to set up and fast to run. Also fixes the issues raised. Fixes #13. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
There currently isn't any CI configured for the project. As a good starting point what we want is
These should be done for each PR as a check, and post merge on master.
Longer term we would want to support automatically building/pushing the module itself to automate the release process. We don't need it in the initial configuration but whatever tooling we pick needs to support it.
The easiest thing would likely be to do this with Github Actions.
The text was updated successfully, but these errors were encountered: