Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base CI w/ PR checks #13

Closed
2 of 3 tasks
patrick-east opened this issue May 13, 2020 · 6 comments · Fixed by #68
Closed
2 of 3 tasks

Add base CI w/ PR checks #13

patrick-east opened this issue May 13, 2020 · 6 comments · Fixed by #68
Labels

Comments

@patrick-east
Copy link
Contributor

patrick-east commented May 13, 2020

There currently isn't any CI configured for the project. As a good starting point what we want is

  • Build the npm module
  • Run unit tests
  • Run lint/formatting check

These should be done for each PR as a check, and post merge on master.

Longer term we would want to support automatically building/pushing the module itself to automate the release process. We don't need it in the initial configuration but whatever tooling we pick needs to support it.

The easiest thing would likely be to do this with Github Actions.

@JasonTruter
Copy link

What CI tool would you think best fit this?

@patrick-east
Copy link
Contributor Author

I think most of the OPA projects are migrating to use GitHub actions, so we might as well too

@JasonTruter
Copy link

Any reason for github actions vs circleci?

@patrick-east
Copy link
Contributor Author

Any reason for github actions vs circleci?

Mostly just to keep the number of services/tools lower for the https://github.com/open-policy-agent org.

If there was some technical reason to pick one over the other I think we're all open to discussing it. I think the assumption is that everything we want to do can be done with any of the usual suspects (travis, circleci, github actions, etc), so with that in mind we are just trying to get projects all onto the same one.

@JasonTruter
Copy link

JasonTruter commented May 21, 2020 via email

@srenatus
Copy link
Contributor

srenatus commented Feb 5, 2021

We've got a few things here now, at least some basic CI: #21 brought in e2e.sh; so we're building an running something for PRs. There're no linting/code checks, afaict, yet, though.

srenatus added a commit that referenced this issue Sep 17, 2021
...using deno, because it's easy to set up and fast to run.

Also fixes the issues raised.

Fixes #13.

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants