Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable linting #68

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Conversation

srenatus
Copy link
Contributor

@srenatus srenatus commented Sep 13, 2021

Uses deno lint and deno fmt --check to lint code and check the formatting respectively.

I've picked the deno tools because they're easy to install (one binary, or the github action) and require no configuration. It seemed like the quickest path to our goal here. That said, I'm no JS expert, so my judgement might be skewed here.

Fixes #13.

@srenatus srenatus force-pushed the sr/enable-linting branch 4 times, most recently from dfadee0 to e8bee4c Compare September 13, 2021 11:44
@srenatus srenatus marked this pull request as ready for review September 13, 2021 11:48
@srenatus srenatus marked this pull request as draft September 14, 2021 07:54
@srenatus
Copy link
Contributor Author

I'd like to add some simple npm run xyz targets to this.

@srenatus srenatus force-pushed the sr/enable-linting branch 2 times, most recently from 5a3bf60 to 91ca5c0 Compare September 17, 2021 05:43
@srenatus srenatus marked this pull request as ready for review September 17, 2021 06:08
...using deno, because it's easy to set up and fast to run.

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
@srenatus srenatus merged commit a123ae2 into open-policy-agent:main Sep 17, 2021
@srenatus srenatus deleted the sr/enable-linting branch September 17, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add base CI w/ PR checks
1 participant