-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose plugin manager options in the SDK config #6662
Labels
Comments
This looks like a good change. Feel free to submit a PR. Thanks! |
xico42
added a commit
to xico42/opa
that referenced
this issue
Apr 3, 2024
This commit adds the possibility to configure the plugin manager with custom options. It will allow SDK users to override the options already provided by the SDK and to futher customize it with configurations that were not previously available. This is an advanced feature as it requires knowledge about the inner workings of OPa. One use case for this is to provide a prometheus registerer and have the status plugin metrics available for the client to use it in a /metrics endpoint, for example. resolves open-policy-agent#6662
xico42
added a commit
to xico42/opa
that referenced
this issue
Apr 3, 2024
This commit adds the possibility to configure the plugin manager with custom options. It will allow SDK users to override the options already provided by the SDK and to futher customize it with configurations that were not previously available. This is an advanced feature as it requires some knowledge about the inner workings of OPA. One use case for this is to provide a prometheus registerer and have the status plugin metrics available for the client to use it in a /metrics endpoint, for example. resolves open-policy-agent#6662
Merged
xico42
added a commit
to xico42/opa
that referenced
this issue
Apr 3, 2024
This commit adds the possibility to configure the plugin manager with custom options. It will allow SDK users to override the options already provided by the SDK and to futher customize it with configurations that were not previously available. This is an advanced feature as it requires some knowledge about the inner workings of OPA. One use case for this is to provide a prometheus registerer and have the status plugin metrics available for the client to use it in a /metrics endpoint, for example. resolves open-policy-agent#6662 Signed-off-by: Francisco Rodrigues <ednofco@gmail.com>
ashutosh-narkar
pushed a commit
that referenced
this issue
Apr 3, 2024
This commit adds the possibility to configure the plugin manager with custom options. It will allow SDK users to override the options already provided by the SDK and to futher customize it with configurations that were not previously available. This is an advanced feature as it requires some knowledge about the inner workings of OPA. One use case for this is to provide a prometheus registerer and have the status plugin metrics available for the client to use it in a /metrics endpoint, for example. resolves #6662 Signed-off-by: Francisco Rodrigues <ednofco@gmail.com>
tsidebottom
pushed a commit
to tsidebottom/opa-
that referenced
this issue
Apr 17, 2024
This commit adds the possibility to configure the plugin manager with custom options. It will allow SDK users to override the options already provided by the SDK and to futher customize it with configurations that were not previously available. This is an advanced feature as it requires some knowledge about the inner workings of OPA. One use case for this is to provide a prometheus registerer and have the status plugin metrics available for the client to use it in a /metrics endpoint, for example. resolves open-policy-agent#6662 Signed-off-by: Francisco Rodrigues <ednofco@gmail.com> Signed-off-by: Thomas Sidebottom <thomas.sidebottom@va.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the underlying problem you're trying to solve?
I am integrating with OPA through its SDK and I have missed the ability to expose the status metrics with prometheus.
If the plugin manager options were exposed to the SDK I could provide a prometheus registry.
Describe the ideal solution
The ideal solution would be to provide a slice of "Manager Options" that would get appended to the list of the default ones that
the SDK already provides.
The SDK client would use it like so:
Describe a "Good Enough" solution
I believe that the ideal solution proposed seems to be pretty straightforward already.
Additional Context
I have tested this proposed solution locally and could provide a PR with the implementation if the idea is accepted.
The steps I followed were:
Expose this new option in the SDK Options
Expose the manager options in the opa struct
Use the extra options in the private configure method of the opa struct
The text was updated successfully, but these errors were encountered: