topdown: Use an underscore instead of a dot in http.send metric name. #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koponen-styra
requested review from
tsandall,
ashutosh-narkar and
patrick-east
|
It's consistent in the sense that @koponen-styra could you add a section to the CHANGELOG.md file under Unreleased: |
koponen-styra
force-pushed
the
http-send-metric-name
branch
from
164129b
to
ae27523
Compare
Currently the recorded metric name is "timer_rego_builtin_http.send_ns" which causes issues for some implementations. Signed-off-by: Teemu Koponen <koponen@styra.com>
koponen-styra
force-pushed
the
http-send-metric-name
branch
from
ae27523
to
fb76dd2
Compare
tsandall
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the recorded metric name is "timer_rego_builtin_http.send_ns" which seems inconsistent.
This is not backwards compatible but before even trying to address that, I thought I should raise the PR to understand is the naming intentional.
Signed-off-by: Teemu Koponen koponen@styra.com