Add a --format=raw option for eval #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm all for it! Thanks for coming up with this. 🚀 |
srenatus
reviewed
Mar 3, 2021
jaspervdj-luminal
force-pushed
the
eval-format-raw
branch
from
c85010b
to
f94cc27
Compare
srenatus
previously approved these changes
Mar 3, 2021
tsandall
previously approved these changes
Mar 3, 2021
There was a problem hiding this comment.
LGTM. @jaspervdj-luminal once you squash the commits, we can merge.
This is a very simple addition but it's proven extremely useful to us since it means you can now use `opa` easily in bash scripts, e.g.: ```bash ACCOUNT_ID="$(opa eval -d accounts.rego --format raw "data.accounts.account")" ``` This means `accounts.rego` can be used by policies as well as e.g. deploy scripts. The naming and functionality is inspired by the `-r` flag from `jq`. In fact, `jq` can be used to replicate this behaviour, but it is a bit nicer to not rely on that system dependency. When multiple queries and expressions are given, they are printed in a simple table format using single newlines and spaces since that is consistent and plays nice with `bash`. Signed-off-by: Jasper Van der Jeugt <jasper@fugue.co>
jaspervdj-luminal
dismissed stale reviews from tsandall and srenatus
via
c87c5c3
jaspervdj-luminal
force-pushed
the
eval-format-raw
branch
from
72d99e5
to
c87c5c3
Compare
srenatus
approved these changes
Mar 4, 2021
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple addition but it's proven extremely useful to us since
it means you can now use
opaeasily in bash scripts, e.g.:ACCOUNT_ID="$(opa eval -d accounts.rego --format raw "data.accounts.account")"This means
accounts.regocan be used by policies as well as e.g. deployscripts.
The naming and functionality is inspired by the
-rflag fromjq. In fact,jqcan be used to replicate this behaviour, but it is a bit nicer to not relyon that system dependency.
I wasn't sure what to do when multiple queries and expressions are given. I
opted to print these in a newline/space separated way since that is consistent
and plays nice with
bash.If this seems like a good addition I'll add some tests to this PR, I wanted
to test the waters first.
Signed-off-by: Jasper Van der Jeugt jasper@fugue.co