ast: parse import without package in resolveRefs #3240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
resolveRefs
ignored Imports when Package is nil.This caused
opa eval --import
option to be ignored without--package
option.This PR makes query compiler generate temporary package with name of ""
(empty string) when package is nil but import one or many imports are provided.
For example, we have two files.
filter1.rego
data.json
Before, we had this error because of no
--package
option.After this PR, we can use
--import
option without any explicit--package
option.Fixes #3228
Signed-off-by: Hiro Osaki hiroyuki.osaki@gmail.com
Thank you for reviewing this PR.