topdown: memoize partial set results #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/issue-822/memoize-partial-sets
branch
from
5f42254
to
8b88a91
Compare
|
I'll incorporate @tsandall's WIP from here https://github.com/tsandall/opa/commits/memoize-partial-sets to capture more cases. Back to draft mode. |
srenatus
force-pushed
the
sr/issue-822/memoize-partial-sets
branch
3 times, most recently
from
66699fd
to
612ab09
Compare
|
So now, if a full extent eval of |
tsandall
reviewed
Jul 7, 2021
srenatus
force-pushed
the
sr/issue-822/memoize-partial-sets
branch
from
93a0547
to
892bf9f
Compare
tsandall
previously approved these changes
Jul 13, 2021
|
LGTM. Just squash and merge when you're ready. Closing out a 3-year old issue feels great :D |
We can either cache individual elements (`data.foo.p["bar"]`), or the full extent of a partial set/object. A cached full extent of the partial would be used when evaluating individual elements of the partial. If the first encounter with a partial set/object has to materialize the full extent with a variable key, like `data.foo.p[x]`, then we cache the fully-evaluated result for `data.foo.p`. Fixes open-policy-agent#822. Co-authored-by: Torin Sandall <torinsandall@gmail.com> Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/issue-822/memoize-partial-sets
branch
from
892bf9f
to
50f96e5
Compare
dolevf
pushed a commit
to dolevf/opa
that referenced
this pull request
Nov 4, 2021
We can either cache individual elements (`data.foo.p["bar"]`), or the full extent of a partial set/object. A cached full extent of the partial would be used when evaluating individual elements of the partial. If the first encounter with a partial set/object has to materialize the full extent with a variable key, like `data.foo.p[x]`, then we cache the fully-evaluated result for `data.foo.p`. Fixes open-policy-agent#822. Co-authored-by: Torin Sandall <torinsandall@gmail.com> Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com> Signed-off-by: Dolev Farhi <farhi.dolev@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can either cache individual elements (
data.foo.p["bar"]), or thefull extent of a partial set/object. A cached full extent of the partial
would be used when evaluating individual elements of the partial.
If the first encounter with a partial set/object has to materialize the
full extent with a variable key, like
data.foo.p[x], then we cache thefully-evaluated result for
data.foo.p.Fixes #822.