build: more SELinux labels for Docker volumes #6061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
srenatus
reviewed
Jun 29, 2023
Makefile
Outdated
| @@ -142,15 +142,15 @@ wasm-sdk-e2e-test: generate | |||
| .PHONY: check | |||
| check: | |||
| ifeq ($(DOCKER_RUNNING), 1) | |||
| docker run --rm -v $(shell pwd):/app -w /app golangci/golangci-lint:${GOLANGCI_LINT_VERSION} golangci-lint run -v | |||
| docker run --rm -v $(shell pwd):/app:Z -w /app golangci/golangci-lint:${GOLANGCI_LINT_VERSION} golangci-lint run -v | |||
There was a problem hiding this comment.
Really? I wouldn't expect the linter to write files
There was a problem hiding this comment.
The linter wants to stat the working directory and fails:
$ make check
docker run --rm -v /home/zregvart/tmp/opa:/app -w /app golangci/golangci-lint:v1.51.0 golangci-lint run -v
level=warning msg="[config_reader] Can't make abs path for \"./...\": stat .: permission denied"
level=info msg="[config_reader] Config search paths: [./ . /root]"
ERROR 2023/06/29 11:35:31 could not discover absolute path: stat .: permission denied
ERROR 2023/06/29 11:35:31 could not discover absolute path: stat .: permission denied
level=warning msg="Failed to discover go env: failed to run 'go env': exit status 1"
level=info msg="[lintersdb] Active 7 linters: [errcheck gosimple govet ineffassign staticcheck typecheck unused]"
level=info msg="[loader] Go packages loading at mode 575 (deps|exports_file|name|types_sizes|compiled_files|files|imports) took 2.118453ms"
level=error msg="Running error: context loading failed: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: cannot determine current directory: stat .: permission denied\n"
level=info msg="Memory: 2 samples, avg is 31.4MB, max is 31.4MB"
level=info msg="Execution took 5.143799ms"
make: *** [Makefile:145: check] Error 3
There was a problem hiding this comment.
Added the read-only (ro) flag to the linter invocation...
Ref open-policy-agent#6054 Signed-off-by: Zoran Regvart <zoran@regvart.com>
zregvart
force-pushed
the
issue/6054-adenum
branch
from
e84c017
to
b462f44
Compare
srenatus
approved these changes
Jun 29, 2023
| else | ||
| @echo "Docker not installed or running. Skipping golangci run." | ||
| endif | ||
|
|
||
| .PHONY: fmt | ||
| fmt: | ||
| ifeq ($(DOCKER_RUNNING), 1) | ||
| docker run --rm -v $(shell pwd):/app -w /app golangci/golangci-lint:${GOLANGCI_LINT_VERSION} golangci-lint run -v --fix | ||
| docker run --rm -v $(shell pwd):/app:Z -w /app golangci/golangci-lint:${GOLANGCI_LINT_VERSION} golangci-lint run -v --fix |
There was a problem hiding this comment.
That make target does write to the files 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
Found two more places where labels need to be propagated.
What are the changes in this PR?
Refines #6055 to include additional labling
Notes to assist PR review:
Tested with and without SELinux enforcement
Further comments:
Ref #6054