update istio envoy tutorial to use AuthorizationPolicy #6426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
howardjohn
reviewed
Nov 27, 2023
anderseknert
force-pushed
the
5911-opa-istio-integration-docs
branch
from
809364e
to
0226448
Compare
ashutosh-narkar
force-pushed
the
5911-opa-istio-integration-docs
branch
from
0226448
to
cbf8013
Compare
docs/content/envoy-tutorial-istio.md
Outdated
| See Istio's [Quick Start](https://istio.io/docs/setup/kubernetes/install/kubernetes/) page to get started. | ||
|
|
||
| If you are using an earlier version of Istio (1.9+), you will have to customize the `AuthorizationPolicy` in the to use the |
There was a problem hiding this comment.
I guess we're referring to the quick_start.yaml file here.
There was a problem hiding this comment.
LGTM. I guess we need to get open-policy-agent/opa-envoy-plugin#492 first?
Signed-off-by: tjons <tyler.schade@solo.io>
tjons
force-pushed
the
5911-opa-istio-integration-docs
branch
from
cbf8013
to
f33aa68
Compare
|
Yes, the opa envoy plugin one should go first. Fixed the error you caught and squashed. |
ashutosh-narkar
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
open-policy-agent/opa-envoy-plugin#492 changes the
quick_start.yamlfile to use the IstioAuthorizationPolicyAPI instead of theEnvoyFilterAPI, per suggestion from @howardjohn (#5911).What are the changes in this PR?
Update the tutorial content for the Istio OPA integration to explain the changes made in open-policy-agent/opa-envoy-plugin#492.