Skip to content

Commit

Permalink
Remove workaround clearning interrpt register
Browse files Browse the repository at this point in the history
For some reason during dumps for DD2 we were seeing the checkstop
bit pop on this 0xf0001a interrupt attn register but we didnt
see anything with getcfam. I am not longer seeing that bit pop
so I think we are safe to remove this

Change-Id: Idb6b4259e9778165bc09c0b4761472d19015aedc
RTC: 179645
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/46710
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
crgeddes authored and dcrowell77 committed Oct 10, 2017
1 parent bc5682a commit 0213310
Showing 1 changed file with 0 additions and 37 deletions.
37 changes: 0 additions & 37 deletions src/usr/isteps/istep06/host_discover_targets.C
Original file line number Diff line number Diff line change
Expand Up @@ -213,36 +213,6 @@ errlHndl_t sendContinueMpiplChipOp()
return l_err;
}

/**
* @brief loop through procs and clear out interrupt registers that
tells us if we have xstop, recoverabale, or an attn
* @return errlHndl_t
*/
errlHndl_t clearInterruptReg()
{
errlHndl_t l_err = nullptr;

TARGETING::TargetHandleList l_procChips;
TARGETING::getAllChips(l_procChips, TARGETING::TYPE_PROC, true);
uint64_t CLEAR_SCOM = 0x0000000000000000;
size_t MASK_SIZE= sizeof(CLEAR_SCOM);

for(const auto & l_chip : l_procChips)
{
//TODO 179645 Determine why we have to clear PERV_ATTN_INTERRUPT_REG during dump MPIPLs on DD2
l_err = deviceWrite(l_chip,
&CLEAR_SCOM,
MASK_SIZE,
DEVICE_SCOM_ADDRESS(PERV_ATTN_INTERRUPT_REG));
if(l_err)
{
break;
}
}

return l_err;
}


/**
* @brief loop through slave quads, make sure clocks are stopped
Expand Down Expand Up @@ -544,13 +514,6 @@ void* host_discover_targets( void *io_pArgs )
{
break;
}

//Clear out interrupt reg for dump path
l_err = clearInterruptReg();
if (l_err)
{
break;
}
}while(0);

}
Expand Down

0 comments on commit 0213310

Please sign in to comment.