Skip to content

Commit

Permalink
Make some FAPI_INF traces that are spamming FW logs into FAPI_DBG
Browse files Browse the repository at this point in the history
In testing this change has removed ~56k lines from the HBFW trace log.
In general these traces are not really needed but they can still be
turned on if we are seeing problems.

Change-Id: I86db95070eed4eb8a45cebb0f918009dd5d37996
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/78755
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/78779
Reviewed-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Tested-by: Christian R. Geddes <crgeddes@us.ibm.com>
  • Loading branch information
crgeddes committed Jun 12, 2019
1 parent 1a8e06d commit 12ef1ff
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ inline fapi2::ReturnCode get_fw_status(const fapi2::Target<fapi2::TARGET_TYPE_OC

// Get data and check for errors
FAPI_TRY(fapi2::getI2c(i_target, l_size, l_cmd_id, o_data));
FAPI_INF( "status returned ( 5 bytes ) : 0x%.02X 0x%.02X 0x%.02X 0x%.02X 0x%.02X",
FAPI_DBG( "status returned ( 5 bytes ) : 0x%.02X 0x%.02X 0x%.02X 0x%.02X 0x%.02X",
o_data[0], o_data[1] , o_data[2], o_data[3], o_data[4]);
fapi_try_exit:
return fapi2::current_err;
Expand Down
6 changes: 3 additions & 3 deletions src/import/generic/memory/lib/utils/mss_field.H
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2018 */
/* Contributors Listed Below - COPYRIGHT 2018,2019 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -327,7 +327,7 @@ inline fapi2::ReturnCode get_field( const fapi2::Target<T>& i_target,
"Conversion error between original %d to converted %d value for %s",
l_temp, o_value, spd::c_str(i_target) );

FAPI_INF("%s: 0x%02x for %s",
FAPI_DBG("%s: 0x%02x for %s",
TT::FIELD_STR,
o_value,
spd::c_str(i_target));
Expand Down Expand Up @@ -378,7 +378,7 @@ inline fapi2::ReturnCode set_field( const fapi2::Target<T>& i_target,
FAPI_TRY( (set_field<E, F>(i_target, i_setting, i_ffdc_codes, io_data)),
"Failed set_field() for %s", spd::c_str(i_target) );

FAPI_INF("%s: Set value of 0x%02x. Data for buffer at byte %d, is now 0x%02x for %s",
FAPI_DBG("%s: Set value of 0x%02x. Data for buffer at byte %d, is now 0x%02x for %s",
TT::FIELD_STR,
i_setting,
BYTE,
Expand Down

0 comments on commit 12ef1ff

Please sign in to comment.