Skip to content

Commit

Permalink
PM: Modified FFDC to avoid corruption of RC in error path.
Browse files Browse the repository at this point in the history
On FSP platform, in case of some errors, HWP captures
certain EX level registers. To ensure availability of
such registers, FSP first attempts special wakeup.
Special wakeup HWP uses FAPI_TRY in its code path. It
is known that in FFDC collection path, use of FAPI_TRY
leads to corruption of original FAPI2 RC. Commit
removes such registers from the capture list.

Key_Cronus_Test=PM_REGRESS

Change-Id: I23ce8b1a8a4a61f71c7b33c1122fcfac905616c4
CQ: SW471606
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83863
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Gregory S Still <stillgs@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: Cronus HW CI <cronushw-ci+hostboot@us.ibm.com>
Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com>
Reviewed-by: AMIT J. TENDOLKAR <amit.tendolkar@in.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83958
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
  • Loading branch information
premsjha authored and crgeddes committed Sep 27, 2019
1 parent 746ec70 commit 1adf748
Showing 1 changed file with 5 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<!-- -->
<!-- OpenPOWER HostBoot Project -->
<!-- -->
<!-- Contributors Listed Below - COPYRIGHT 2015,2018 -->
<!-- Contributors Listed Below - COPYRIGHT 2015,2019 -->
<!-- [+] International Business Machines Corp. -->
<!-- -->
<!-- -->
Expand Down Expand Up @@ -34,6 +34,8 @@
for a completed transition.
</description>

<ffdc>EX</ffdc>

<collectFfdc>p9_eq_clear_atomic_lock,EQ</collectFfdc>

<collectRegisterFfdc>
Expand All @@ -46,11 +48,6 @@
<target>EQ</target>
<targetType>TARGET_TYPE_EQ</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>CHECK_MASTER_STOP15_FFDC_REGS_EX</id>
<target>EX</target>
<targetType>TARGET_TYPE_EX</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>CHECK_MASTER_STOP15_FFDC_REGS_EC</id>
<target>EC</target>
Expand All @@ -77,6 +74,8 @@
but the achieved level is not appropriate.
</description>

<ffdc>EX</ffdc>

<collectFfdc>p9_eq_clear_atomic_lock,EQ</collectFfdc>

<collectRegisterFfdc>
Expand All @@ -89,11 +88,6 @@
<target>EQ</target>
<targetType>TARGET_TYPE_EQ</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>CHECK_MASTER_STOP15_FFDC_REGS_EX</id>
<target>EX</target>
<targetType>TARGET_TYPE_EX</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>CHECK_MASTER_STOP15_FFDC_REGS_EC</id>
<target>EC</target>
Expand Down

0 comments on commit 1adf748

Please sign in to comment.