Skip to content

Commit

Permalink
Skip OCMB MMIO Response polling in hostboot
Browse files Browse the repository at this point in the history
Until simics gets their issues modeling the endianess of the doorbell
register we must skip the polling. This was working before we added the
polling we should be okay to skip this until we hit hardware but we
would like to get this resolved before then.

Change-Id: I8ee1cdc52d5c4633eceeb3f4270200c2988bda4c
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76843
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Glenn Miles <milesg@ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76881
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Tested-by: Christian R. Geddes <crgeddes@us.ibm.com>
  • Loading branch information
crgeddes committed May 3, 2019
1 parent 19a436e commit 292334f
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -516,8 +516,12 @@ fapi2::ReturnCode getRSP(
{
std::vector<uint8_t> l_data(static_cast<int>(sizeof(o_rsp)));

//TODO RTC: 209669 Remove workaround when simics model issue fixes
// endianess issues with doorbell register
#ifndef CONFIG_AXONE_BRING_UP
// Polls for the response to be ready first
FAPI_TRY(poll_for_response_ready(i_target));
#endif

FAPI_INF("Reading the response buffer...");
FAPI_TRY(fapi2::getMMIO(i_target, EXPLR_IB_RSP_ADDR, BUFFER_TRANSACTION_SIZE, l_data));
Expand Down

0 comments on commit 292334f

Please sign in to comment.