Skip to content

Commit

Permalink
Enable bad training bits workaround, always
Browse files Browse the repository at this point in the history
The lab still is trying figure out what EC number this
needs to be enabled for.  Until then we are running dirty.

Change-Id: I773e5bc0427e344a0b45c6140b0d1722437cf457
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36180
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Dev-Ready: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36235
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
aamarin authored and dcrowell77 committed Feb 12, 2017
1 parent d04e4b8 commit 3db9e21
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,10 @@ fapi_try_exit:
template< fapi2::TargetType T >
inline bool chip_ec_feature_mss_training_bad_bits(const fapi2::Target<T>& i_target)
{
// TODO RTC:165862 - need to get the minor EC number and check that in here.
// TODO RTC:168964 Enable training bad bits workaround at appropriate EC levels
// Running dirty until we know what EC major & minor number we want to add this to.

#ifdef ALWAYS_DO_TRAINING_BAD_BITS_WORKAROUND
const auto l_chip = mss::find_target<fapi2::TARGET_TYPE_PROC_CHIP>(i_target);
uint8_t l_value = 0;
uint8_t l_do_value = 0;
Expand All @@ -251,6 +254,9 @@ fapi_try_exit:
uint64_t(fapi2::current_err), mss::c_str(i_target));
fapi2::Assert(false);
return false;
#else
return true;
#endif
}

///
Expand Down

0 comments on commit 3db9e21

Please sign in to comment.