Skip to content

Commit

Permalink
PM: Move to chip EC based #V validity checking in p9_pstate_parameter…
Browse files Browse the repository at this point in the history
…_block

- Was always returning SUCCESS which caused p9_hcode_image_build to not
  properly terminate (false error logs)
- Added EC feature attribute to skip #V validity checking and thus disabling
  pstates for Nimbus < 20 and Cumulus < 11
- Initalized wof io_size to 0.
- Rebased
- Added override attribute ATTR_SYSTEM_POUNDV_VALIDITY_HALT_DISABLE to disable
  killing the IPL upon #V validity check failure.  Disables Pstates and
  continues.  This allow the use of parts that don't have good #V for other,
  non-Pstate oriented purposes.  Marked with new <overrideOnly/> tag.

Change-Id: Ia238af9758ae1fe35d39fa536d73ec41e85f9498
CQ: SW400102
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45185
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com>
Reviewed-by: Juan R. Medina <jrmedina@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45190
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
stillgs authored and dcrowell77 committed Sep 23, 2017
1 parent 254e740 commit af3f8bf
Show file tree
Hide file tree
Showing 4 changed files with 325 additions and 155 deletions.
3 changes: 1 addition & 2 deletions src/import/chips/p9/procedures/hwp/pm/p9_hcode_image_build.C
Original file line number Diff line number Diff line change
Expand Up @@ -4280,9 +4280,8 @@ fapi2::ReturnCode p9_hcode_image_build( CONST_FAPI2_PROC& i_procTgt,
//customize magic word based on endianess
customizeMagicWord( pChipHomer );

FAPI_IMP("<< p9_hcode_image_build" );

fapi_try_exit:
FAPI_IMP("<< p9_hcode_image_build" );
return fapi2::current_err;
}

Expand Down

0 comments on commit af3f8bf

Please sign in to comment.