Travis CI testing #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes things for old versions of msgmerge such as the one used on Travis CI (Ubuntu 14.04) Signed-off-by: Daniel Axtens <dja@axtens.net>
Signed-off-by: Daniel Axtens <dja@axtens.net>
sammj
reviewed
Nov 15, 2016
| @@ -57,7 +57,7 @@ USE_MSGCTXT = no | |||
| # Useful options are in particular: | |||
| # --previous to keep previous msgids of translated messages, | |||
| # --quiet to reduce the verbosity. | |||
| MSGMERGE_OPTIONS = --add-location=never | |||
| MSGMERGE_OPTIONS = --no-location | |||
There was a problem hiding this comment.
Commit 55ffff9 did the inverse of this, IIRC it was because of a difference between older and newer versions of msgmerge. It could be that adding both may work, I'll have to check.
There was a problem hiding this comment.
It looks like the ability to take a parameter for add-location was only added in mid-2014, which would explain why it isn't in 14.04: https://lists.gnu.org/archive/html/bug-gettext/2014-03/msg00021.html
What is the difference between --add-location=never and --no-location? My reading of the man page was that they were identical...
|
Ignore the new commits, I was ... testing something ... |
|
Merged as 865097f manually, thanks! What's that about the date? 20 something? What? I can't hear you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sam,
This allows testing with Travis CI.
If you merge it, you will also want to turn on testing for this repository in Travis CI.
Regards,
Daniel
This change is