-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version numbering #192
Comments
Is it possible to set version to |
AFAIK no, that's pretty much the point of this issue. |
@dstebila what do you think? |
If you're limited to |
I'm afraid that this would get confusing as to which version of liboqs we're packaging though... |
Well, yes, but I don't know what other options there are. |
What do you think about basically moving OQS versioning one position to the left? ie. Another option could be to do Or doing |
Oooh, I like 0.7.200. I had also thought of the 7.2.0 idea but it seemed too drastic, and would lose the oomph of a 1.0 when it happens. |
Okay at some point I will transition over to that versioning scheme. |
Starting from 0.8.0, we will follow this versioning scheme. |
Oh, crap: this doesn't actually work for versions like |
Perhaps we do need to move to the |
One option to resolve this is to version the crates in a semver way uncoupled from liboqs version, but append a build annotation with liboqs version, like libgit2-sys does ( |
TIL that format. It does seem that it's completely ignored and I'm not sure how visible that would be to users, though... https://doc.rust-lang.org/cargo/reference/resolver.html#version-metadata |
At the very least it's visible in crates.io and Cargo.lock entries; since we already instruct users to do |
I mean, specifying |
But if we do the |
I'd assume following semver as close as reasonable, e.g.:
|
BREAKING CHANGE: Versioning no longer follows `liboqs` versioning. See #192
I have updated the versioning scheme and we're no longer following upstream. |
We're currently using the liboqs version numbering scheme, which does make it clear which version we're bundling. However, that also means that we can't really release patch versions. This is sometimes a problem: #189
One possibility would be to do the following: Release
0.7.2
as7.2.0
so that we can actually issue patch releases.The text was updated successfully, but these errors were encountered: