Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include liboqs/.Cmake in published package #189

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Include liboqs/.Cmake in published package #189

merged 1 commit into from
Mar 1, 2023

Conversation

dadada
Copy link
Contributor

@dadada dadada commented Feb 28, 2023

This fixes #188.

@thomwiggers
Copy link
Member

Thanks and TIL. Assuming the checks pass this should get merged automatically.

@thomwiggers thomwiggers merged commit aa7d6f5 into open-quantum-safe:main Mar 1, 2023
@wucke13
Copy link
Contributor

wucke13 commented Mar 1, 2023

@dadada Thank you for finding this! @thomwiggers Thank you for reacting so fast! Would it be possible to create a patch release with this change?

@thomwiggers
Copy link
Member

I've been sticking to the liboqs version numbers and unfortunately I don't think that I can release "package versions", as I think that in Rust you can only use MAJOR.MINOR.PATCH version numbers and OQS already hogs every one of those fields.

This was referenced Mar 4, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomwiggers thomwiggers thomwiggers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cmake files are not included in package
3 participants
@dadada @thomwiggers @wucke13