Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use cycle counter on ARM32 #1485

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Don't use cycle counter on ARM32 #1485

merged 1 commit into from
Jun 1, 2023

Conversation

dstebila
Copy link
Member

Fixes #1483.

  • [No] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [No] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@dstebila dstebila self-assigned this May 31, 2023
@dstebila dstebila added this to the 0.8.0 milestone May 31, 2023
@dstebila dstebila marked this pull request as ready for review May 31, 2023 16:51
@dstebila dstebila requested a review from xvzcf as a code owner May 31, 2023 16:51
@dstebila dstebila requested review from baentsch and removed request for xvzcf May 31, 2023 16:52
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically LGTM as the #define else branches take over -- just wondering whether it'd also be sensible to purge all references to "_OQS_RASPBERRY_PI" then (?)

@dstebila dstebila merged commit 3e25479 into main Jun 1, 2023
@dstebila dstebila deleted the ds-arm32-benchmark branch June 1, 2023 00:02
@vt-alt
Copy link
Contributor

vt-alt commented Jun 1, 2023

Thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

40 tests fail on ARM32 (armv7hf): AssertionError: Got unexpected return code -4
3 participants