Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing with new liboqs algorithm list. #143

Merged
merged 1 commit into from May 23, 2023
Merged

Syncing with new liboqs algorithm list. #143

merged 1 commit into from May 23, 2023

Conversation

xvzcf
Copy link

@xvzcf xvzcf commented May 17, 2023

No description provided.

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There doesn't seem to be any interest for documentation of previous algorithm variants in openssh, right? Linking to open-quantum-safe/oqs-provider#163 to get agreement on this.

@csosto-pk
Copy link

Thx. Waiting for this to get merged, so I test again.

@dstebila
Copy link
Member

I don't think there's a need to archive old method names.

We do want to make sure we are using new method names for incompatible variants due to algorithm updates. The SPHINCS+ updates are compatibility breaking, but the name change also leads to new method names, so we're good there.

However this does raise the question if we should fix the earlier oversight (as noted in discussion in #134) of not following SSH conventions for non-standardized names. In particular, should we add an @openquantumsafe.org suffix to any new names that we're introducing here?

@csosto-pk
Copy link

However this does raise the question if we should fix the earlier oversight (as noted in discussion in #134) of not following SSH conventions for non-standardized names. In particular, should we add an @openquantumsafe.org suffix to any new names that we're introducing here?

Imo, it is not worth the pain. You can follow the nomenclature when you make compatibility breaking changes and have to update the SSH method name. No need to update everything that you have been using for so long.

@baentsch
Copy link
Member

Our convention is that the author merges PRs once approved, except stated otherwise, right? So why has this not been merged? Who else needs to approve? This is holding up open-quantum-safe/oqs-demos#201 and with it, doing downstream testing of the release of liboqs (as well as @csosto-pk and anyone else interested in using oqs-openssh with the latest liboqs).

@dstebila dstebila merged commit eb9950c into OQS-v8 May 23, 2023
2 checks passed
@dstebila dstebila deleted the alg-update branch May 23, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants