Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream algorithm naming update #201

Merged
merged 2 commits into from
May 27, 2023
Merged

upstream algorithm naming update #201

merged 2 commits into from
May 27, 2023

Conversation

baentsch
Copy link
Member

Copy link
Member Author

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xvzcf I intentionally refrained from making the changes you've introduced in this commit as we have no control over what wolfssl does in their code (keeping or removing these algorithms). @anhu: Can you comment?

@anhu
Copy link
Contributor

anhu commented May 24, 2023

It appears the changes here remove Dilithium AES and Kyber 90S variants. That is in line with what we have done in the wolfSSL library as well so I am in full support.

@baentsch , I'm good with this change.

Warm regards, Anthony

@xvzcf
Copy link
Contributor

xvzcf commented May 26, 2023

Is there a reason the wireshark changes were undone?

@baentsch
Copy link
Member Author

Is there a reason the wireshark changes were undone?

No. Don't understand that. Would you want to add it again and then merge (I'm away from my Computer right now)?

@baentsch baentsch merged commit 5d99ebc into main May 27, 2023
11 checks passed
@baentsch baentsch deleted the mb-algnameupdate branch May 27, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants