Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposed project scorecards #196

Closed
wants to merge 2 commits into from

Conversation

ryjones
Copy link
Contributor

@ryjones ryjones commented May 16, 2024

Per this issue, provisionally add scorecards

@ryjones ryjones requested review from dstebila and baentsch May 16, 2024 10:41
@ryjones
Copy link
Contributor Author

ryjones commented May 16, 2024

@planetf1

Split table to move externals and tooling

Signed-off-by: Ry Jones <ry@linux.com>
Signed-off-by: Ry Jones <ry@linux.com>
@ryjones ryjones marked this pull request as ready for review May 16, 2024 11:09
Copy link

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryjones This is proactively adding the links to the badges, which will be available when the actual scorecard work is in place?

@ryjones
Copy link
Contributor Author

ryjones commented May 16, 2024

Yes. For now it will show a "missing project" bug:

Screenshot 2024-05-16 at 05 22 09

@dstebila
Copy link
Member

I would be tempted to focus the effort on resolving issues arising from the first few scorecards (and evaluating the value of that) before taking on scorecards for all the projects.

@baentsch
Copy link
Member

Seconding the comment by @dstebila above and repeating my concerns from the unmerged PR regarding this on liboqs I consider it premature publishing results of "security score cards" before a) they have been done and b) before there's an agreed-upon plan to mitigate/resolve findings -- particularly for a project doing (at the face of it) security software.

Already for the existing score cards the question: Are there issues in github showing the path to score improvement? Are those issues assigned people to implement them? Did these people agree on a timeline when to land these improvements? If this does not exist, you'd accept publishing bad scores for an infinite time. That I'd call corrosive for a project's reputation:

If I were looking at this as a person responsible for deciding whether to use OQS or develop my own PQ software in-house, I'd surely opt for the second seeing these results.

@planetf1
Copy link

Getting liboqs clean was the first step we agreed to. Nearly there (I have some doc updates).

open-quantum-safe/tsc#27 can track rolling this out to more repos - I think the next target should be oqsprovider

If there's concern about publishing the results

  • we can continue with the approach of starting on a PR to implement scorecard & add required mitigations
  • We could remove the links to the scorecard badge until a repo is 'done' with pr merged.

@baentsch
Copy link
Member

I think the next target should be oqsprovider

I adamantly object to that until there's more committed and achieved contributors and at least two more committed maintainers to that sub project.

@planetf1
Copy link

I mentioned oqsprovider since it's a super asset & I know it's being used.

There's plenty to do so will work through the other items, then we'll be in a better state to review any impacts/concerns

@daisy-row daisy-row closed this by deleting the head repository Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants