Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ament_cmake_vendor_package #11

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Switch to ament_cmake_vendor_package #11

merged 1 commit into from
Jul 14, 2023

Conversation

cottsay
Copy link
Contributor

@cottsay cottsay commented Jun 15, 2023

@cottsay
Switch to ament_cmake_vendor_package
4c33da1 
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay requested a review from Yadunund June 15, 2023 16:44
@cottsay cottsay self-assigned this Jun 15, 2023
@Yadunund
Copy link
Member

Is ament_cmake_vendor_package not distributed on humble? 🤔

Although main targets rolling, ideally we'd like to have main also compile with humble.

@cottsay
Copy link
Contributor Author

cottsay commented Jun 18, 2023

Is ament_cmake_vendor_package not distributed on humble?

It is not, though we could probably backport it.

@cottsay
Copy link
Contributor Author

cottsay commented Jun 26, 2023

@ros-pull-request-builder retest this please

Yadunund
Yadunund approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting ament_cmake_vendor_package to humble! CI is passing so I will merge this in.

@Yadunund Yadunund merged commit 4ab0c24 into main Jul 14, 2023
3 checks passed
@Yadunund Yadunund deleted the cottsay/ament_vendor branch July 14, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Yadunund approved these changes

Assignees

@cottsay cottsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cottsay @Yadunund