Support vendor-provided pybind11 upstream #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This vendor package depends on the pybind11_vendor package. That package will conditionally build pybind11 from source if needed. A package downstream of a vendor package usually needs to `find_package` the upstream vendor package for the vendored payload to be discoverable by CMake. Since this package itself is a vendor package, the way we can accomplish this is to find_package pybind11 on the vendored package's behalf and specifically tell it where to look. Signed-off-by: Scott K Logan <logans@cottsay.net>
|
This should address the recent build regression on RHEL: https://build.ros2.org/job/Rbin_rhel_el864__pybind11_json_vendor__rhel_8_x86_64__binary/215/ We'll need to backport this change to all supported distros as well. |
youliangtan
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vendor package depends on the pybind11_vendor package. That package will conditionally build pybind11 from source if needed. A package downstream of a vendor package usually needs to
find_packagethe upstream vendor package for the vendored payload to be discoverable by CMake.Since this package itself is a vendor package, the way we can accomplish this is to find_package pybind11 on the vendored package's behalf and specifically tell it where to look.