-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update galactic branch #202
Conversation
Signed-off-by: Xi Yu Oh <xiyu@openrobotics.org> Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Dev Manek <manekdev2001@gmail.com> Co-authored-by: Grey <grey@openrobotics.org> Co-authored-by: Aaron Chong <aaronchongth@gmail.com> Co-authored-by: Luca Della Vedova <luca@openrobotics.org> Co-authored-by: Yadu <yadunund@gmail.com> Co-authored-by: youliang <tan_you_liang@hotmail.com> Co-authored-by: Xiyu <ohxiyu@gmail.com> Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org> Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@gmail.com>
9c41f54
to
c442c2c
Compare
Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nightly fails for some issue with Python3 requests, unrelated to this PR, stack trace here for reference:
2022-09-08T02:25:54.4520766Z Traceback (most recent call last):
2022-09-08T02:25:54.4521136Z File "/__w/rmf/rmf/ros_ws/install/rmf_building_map_tools/lib/rmf_building_map_tools/building_map_generator", line 33, in <module>
2022-09-08T02:25:54.4521718Z sys.exit(load_entry_point('rmf-building-map-tools', 'console_scripts', 'building_map_generator')())
2022-09-08T02:25:54.4522202Z File "/__w/rmf/rmf/ros_ws/install/rmf_building_map_tools/lib/rmf_building_map_tools/building_map_generator", line 25, in importlib_load_entry_point
2022-09-08T02:25:54.4522566Z return next(matches).load()
2022-09-08T02:25:54.4522862Z File "/usr/lib/python3.8/importlib/metadata.py", line 77, in load
2022-09-08T02:25:54.4523232Z module = import_module(match.group('module'))
2022-09-08T02:25:54.4523549Z File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
2022-09-08T02:25:54.4523951Z return _bootstrap._gcd_import(name[level:], package, level)
2022-09-08T02:25:54.4524259Z File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
2022-09-08T02:25:54.4524580Z File "<frozen importlib._bootstrap>", line 991, in _find_and_load
2022-09-08T02:25:54.4524912Z File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
2022-09-08T02:25:54.4525336Z File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
2022-09-08T02:25:54.4525656Z File "<frozen importlib._bootstrap_external>", line 848, in exec_module
2022-09-08T02:25:54.4526003Z File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
2022-09-08T02:25:54.4526417Z File "/__w/rmf/rmf/ros_ws/build/rmf_building_map_tools/building_map_generator/building_map_generator.py", line 3, in <module>
2022-09-08T02:25:54.4526780Z from building_map.generator import Generator
2022-09-08T02:25:54.4527141Z File "/__w/rmf/rmf/ros_ws/build/rmf_building_map_tools/building_map/generator.py", line 4, in <module>
2022-09-08T02:25:54.4527463Z from .building import Building
2022-09-08T02:25:54.4527799Z File "/__w/rmf/rmf/ros_ws/build/rmf_building_map_tools/building_map/building.py", line 20, in <module>
2022-09-08T02:25:54.4528099Z from .level import Level
2022-09-08T02:25:54.4528429Z File "/__w/rmf/rmf/ros_ws/build/rmf_building_map_tools/building_map/level.py", line 15, in <module>
2022-09-08T02:25:54.4528736Z from .floor import Floor
2022-09-08T02:25:54.4529036Z File "/__w/rmf/rmf/ros_ws/build/rmf_building_map_tools/building_map/floor.py", line 9, in <module>
2022-09-08T02:25:54.4529401Z from .material_utils import (add_pbr_material, get_pbr_textures,
2022-09-08T02:25:54.4529782Z File "/__w/rmf/rmf/ros_ws/build/rmf_building_map_tools/building_map/material_utils.py", line 2, in <module>
2022-09-08T02:25:54.4530071Z import requests
2022-09-08T02:25:54.4530471Z File "/usr/lib/python3/dist-packages/requests/__init__.py", line 95, in <module>
2022-09-08T02:25:54.4530795Z from urllib3.contrib import pyopenssl
2022-09-08T02:25:54.4531233Z File "/usr/lib/python3/dist-packages/urllib3/contrib/pyopenssl.py", line 46, in <module>
2022-09-08T02:25:54.4531519Z import OpenSSL.SSL
2022-09-08T02:25:54.4531907Z File "/usr/lib/python3/dist-packages/OpenSSL/__init__.py", line 8, in <module>
2022-09-08T02:25:54.4532209Z from OpenSSL import crypto, SSL
2022-09-08T02:25:54.4532606Z File "/usr/lib/python3/dist-packages/OpenSSL/crypto.py", line 1553, in <module>
2022-09-08T02:25:54.4532905Z class X509StoreFlags(object):
2022-09-08T02:25:54.4533323Z File "/usr/lib/python3/dist-packages/OpenSSL/crypto.py", line 1573, in X509StoreFlags
2022-09-08T02:25:54.4533645Z CB_ISSUER_CHECK = _lib.X509_V_FLAG_CB_ISSUER_CHECK
2022-09-08T02:25:54.4534060Z AttributeError: module 'lib' has no attribute 'X509_V_FLAG_CB_ISSUER_CHECK'
With the new commits, I think we have progressed a little bit. https://github.com/open-rmf/rmf/runs/8254192916?check_suite_focus=true#step:7:43856 Can some of you take a look into those failing tests or ping someone who can know about it? |
I think the simulation plugins listed there would indeed be needed in galactic, otherwise simulation wouldn't work.
I believe the
I'm not sure what we can do about it, since it seems to be due to a test on a third party library |
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
bc406a2
to
02e2681
Compare
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
f954325
to
8593c37
Compare
This reverts commit 3f1021b. Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
8593c37
to
e631f71
Compare
You are right. My fault, thank you.
I'm gonna try looking into this.
It's a third-party library but I think the test that is failing is ours, right? https://github.com/open-rmf/rmf_traffic/blame/main/rmf_traffic/test/unit/fcl_test.cpp |
Investigating this. Notes for myself and anyone who want to follow this. This is the call that @luca-della-vedova suggested to be failing https://github.com/open-rmf/rmf_utils/blob/main/rmf_utils/CMakeLists.txt#L95 and the The code of ament_uncrustify command itself: OPTION 1: As we are working on Galactic I'm debugging and I see that it only looks to exclude names of subdirectories in the current directory. Any ideas on how to get through this as it is released? OPTION 2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @orensbruli for the investigation!
With Galactic going EOL in November I don't know how likely it is that upstream fixes will be given a high priority. It seems that both fixes (timeout and exclude logic) are upstream so there isn't much we can do about them other than possibly commenting failing tests.
I think we can go ahead and merge this in and accept that galactic nightlies will only become green if the upstream PR is merged (and the rmf_traffic
failure investigated).
This PR
main
intogalactic
rmf.repos
file to checkoutgalactic-devel
branches of the Open-RMF repos which has recently been created.Moving forward
main
will be supported onhumble
. See #165We can add instructions to that PR to inform users to use the
galactic
version of thermf.repos
file if the would like to buildOpen-RMF
from source +galactic