Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task request time and initiator in task request #35

Merged
merged 3 commits into from Jun 15, 2023
Merged

Task request time and initiator in task request #35

merged 3 commits into from Jun 15, 2023

Conversation

aaronchongth
Copy link
Member

New feature implementation

Implemented feature

aaronchongth and others added 2 commits April 16, 2023 17:49
@aaronchongth
Task request time and initiator in task request
2169780 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@Angatupyry
Date Request and Initiator field in task_state (#34)
7ba2776 
* Add unix_millis_request_time property in task_state

Signed-off-by: fierro <fierrofenix@gmail.com>

* Change unix_millis_request_time from task_state property to booking property

Signed-off-by: fierro <fierrofenix@gmail.com>

* Add initiator as booking property in taskstate

Signed-off-by: fierro <fierrofenix@gmail.com>

---------

Signed-off-by: fierro <fierrofenix@gmail.com>
@aaronchongth aaronchongth mentioned this pull request Apr 17, 2023
Merged
@aaronchongth aaronchongth mentioned this pull request Apr 17, 2023
Merged
@aaronchongth
Use requester instead of initiator
4b7b9fe 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth mentioned this pull request May 9, 2023
Merged
5 tasks
Yadunund
Yadunund approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good to me. But let's hold off on merging until some pkg maintenance work is completed.

@aaronchongth
Copy link
Member Author

Thanks for the review! I'll leave the final button push to you when it's ready then @Yadunund

mxgrey
mxgrey approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, these are definitely valuable fields to support.

@Yadunund Yadunund merged commit 580a828 into main Jun 15, 2023
1 check passed
@Yadunund Yadunund deleted the feat/task-request-time-and-initiator branch June 15, 2023 07:22
@Yadunund
Copy link
Member

@aaronchongth this should be safe to backport to iron and humble. Do you mind opening those PRs?

aaronchongth added a commit that referenced this pull request Jun 15, 2023
@aaronchongth
Task request time and initiator in task request (#35)
16a02c9 
* Task request time and initiator in task request

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Date Request and Initiator field in task_state (#34)

* Add unix_millis_request_time property in task_state

Signed-off-by: fierro <fierrofenix@gmail.com>

* Change unix_millis_request_time from task_state property to booking property

Signed-off-by: fierro <fierrofenix@gmail.com>

* Add initiator as booking property in taskstate

Signed-off-by: fierro <fierrofenix@gmail.com>

---------

Signed-off-by: fierro <fierrofenix@gmail.com>

* Use requester instead of initiator

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: fierro <fierrofenix@gmail.com>
Co-authored-by: César Rolón <37310205+Angatupyry@users.noreply.github.com>
(cherry picked from commit 580a828)
aaronchongth added a commit that referenced this pull request Jun 15, 2023
@aaronchongth @Angatupyry
Task request time and initiator in task request (#35)
ba0f139 
* Task request time and initiator in task request

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Date Request and Initiator field in task_state (#34)

* Add unix_millis_request_time property in task_state

Signed-off-by: fierro <fierrofenix@gmail.com>

* Change unix_millis_request_time from task_state property to booking property

Signed-off-by: fierro <fierrofenix@gmail.com>

* Add initiator as booking property in taskstate

Signed-off-by: fierro <fierrofenix@gmail.com>

---------

Signed-off-by: fierro <fierrofenix@gmail.com>

* Use requester instead of initiator

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: fierro <fierrofenix@gmail.com>
Co-authored-by: César Rolón <37310205+Angatupyry@users.noreply.github.com>
(cherry picked from commit 580a828)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth mentioned this pull request Jun 15, 2023
Merged
aaronchongth added a commit that referenced this pull request Jun 15, 2023
@aaronchongth @Angatupyry
Task request time and initiator in task request (#35)
846bd04 
* Task request time and initiator in task request

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Date Request and Initiator field in task_state (#34)

* Add unix_millis_request_time property in task_state

Signed-off-by: fierro <fierrofenix@gmail.com>

* Change unix_millis_request_time from task_state property to booking property

Signed-off-by: fierro <fierrofenix@gmail.com>

* Add initiator as booking property in taskstate

Signed-off-by: fierro <fierrofenix@gmail.com>

---------

Signed-off-by: fierro <fierrofenix@gmail.com>

* Use requester instead of initiator

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: fierro <fierrofenix@gmail.com>
Co-authored-by: César Rolón <37310205+Angatupyry@users.noreply.github.com>
(cherry picked from commit 580a828)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth mentioned this pull request Jun 15, 2023
Merged
Yadunund pushed a commit that referenced this pull request Jun 15, 2023
@aaronchongth @Angatupyry
Task request time and initiator in task request (#35) (#41)
1ee5cb8 
* Task request time and initiator in task request



* Date Request and Initiator field in task_state (#34)

* Add unix_millis_request_time property in task_state



* Change unix_millis_request_time from task_state property to booking property



* Add initiator as booking property in taskstate



---------



* Use requester instead of initiator



---------




(cherry picked from commit 580a828)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: fierro <fierrofenix@gmail.com>
Co-authored-by: César Rolón <37310205+Angatupyry@users.noreply.github.com>
Yadunund pushed a commit that referenced this pull request Jun 15, 2023
@aaronchongth @Angatupyry
Task request time and initiator in task request (#35) (#42)
b52aa4b 
* Task request time and initiator in task request



* Date Request and Initiator field in task_state (#34)

* Add unix_millis_request_time property in task_state



* Change unix_millis_request_time from task_state property to booking property



* Add initiator as booking property in taskstate



---------



* Use requester instead of initiator



---------




(cherry picked from commit 580a828)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: fierro <fierrofenix@gmail.com>
Co-authored-by: César Rolón <37310205+Angatupyry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxgrey mxgrey mxgrey approved these changes

@Yadunund Yadunund Yadunund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aaronchongth @Yadunund @mxgrey @Angatupyry