Add parameter to force Ignition Version #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
aaronchongth
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
This PR adds a parameter to force the Ignition Gazebo version when running
rmf_demos_ignlaunch files.Implementation description
The plugins in rmf_simulation are compiled against a specific version of Ignition Gazebo and if a different version of Ignition than the one used to compile the plugins was to be ran, the simulation would crash.
By default, the
ign gazeboCLI runs the most recent version of Gazebo, hence if a user was to install a newer version than the one supported demos would stop working.This PR introduces a
ignition_versionparameter tormf_demos_ignthat defaults to the version plugins are built against. Since it specifies Fortress it should be merged together with open-rmf/rmf_simulation#70 to complete our migration. Users who wish to use different Ignition version can change the parameter value by doing, for example:ros2 launch rmf_demos_ign office.launch.xml ignition_version:=6