-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ignition Fortress #70
Conversation
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling the migration! I've been running some tests and have been unable to get loop requests to run for more than 1 loop. I tried using both the RMF panel and dashboard to issue the request, Could you help take a look into that, just in case it is happening only on my end?
Could you perhaps start a PR to add ros_ign
to rmf/rmf.repos
as well? Might be a good idea to have that merged in first before this migration.
62f5dd2
to
ab94ed3
Compare
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
I can reproduce the issue with loop requests with more than one loop not happening, it seems once the first loop is finished the robot doesn't receive a new path request so my guess is that the robot's state estimation by the fleet adapter puts it in some state where it doesn't detect the robot's first loop as completed, hence doesn't issue the followup loop request.
Done open-rmf/rmf#144 |
Yup, as long as we know that it is not related to this PR we can just start an issue. I can spend a little bit more time to diagnose it. Per DM, after the lift plugin segfault is fixed, this should be good to merge. |
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Should be good now 254d720 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the issue! LGTM
New feature implementation
Implemented feature
Closes #69, migrating to Ignition Fortress.
Implementation description
Together with bumping dependencies on
CMakeLists
andpackage.xml
, we can use a new utility function to enable components which allows us to remove a lot of boilerplate component creation code resulting in a hundred or so lines of code being removed.Note that this PR will make the binary
ros_ign
available in Galactic incompatible with rmf_simulation since theros_ign
package in galactic supports Edifice while theros_ign
in Rolling (and future Humble) will support Fortress.Hence users who wish to use Ignition Fortress with Galactic should switch to build
ros_ign
from source