Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/get building map #75

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

mattbooker
Copy link
Contributor

New feature implementation

Implemented feature

Added an endpoint (/building_map) to receive the BuildingMap message from.

This PR is dependent on the following PR in order to work: open-rmf/rmf_traffic_editor#377

@mattbooker mattbooker changed the title Added building map to api server Feature/get building map Aug 11, 2021
Signed-off-by: Matthew Booker <mattbooker97@gmail.com>
@youliangtan
Copy link
Member

Thanks for the PR. Tested, the endpoint works as described. Is it possible to fix a few lines of pycodestyle linting issue? Thanks

@youliangtan youliangtan self-requested a review September 1, 2021 08:11
Signed-off-by: Matthew Booker <mattbooker97@gmail.com>
…ture/get_building_map

Signed-off-by: Matthew Booker <mattbooker97@gmail.com>
Copy link
Member

@youliangtan youliangtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@youliangtan youliangtan merged commit 2b6b759 into open-rmf:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants