Feature/wall graph #377
Merged
Feature/wall graph #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Booker <mattbooker97@gmail.com>
mattbooker
force-pushed
the
feature/wall_graph
branch
from
619644d
to
0a6d179
Compare
arjo129
previously requested changes
Aug 11, 2021
There was a problem hiding this comment.
These changes could be useful outside of the current ar-kit context as well. There are several minor code style changes needed as marked by the pycodestyle checker.
https://github.com/open-rmf/rmf_traffic_editor/pull/377/checks?check_run_id=3298220632
Also all files should end in a new line.
Signed-off-by: Matthew Booker <mattbooker97@gmail.com>
codebot
approved these changes
Aug 27, 2021
|
@arjo129 looks like the requested |
codebot
dismissed
arjo129’s stale review
Requested changes have been completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
The
building_map_servernow populates the wall graph field within the Level message