migrate rmf_panel js component to a new repo #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youliang <tan_you_liang@hotmail.com>
marcoag
approved these changes
Sep 22, 2021
|
Great work! awesome stuff! |
marcoag
pushed a commit
that referenced
this pull request
Sep 22, 2021
* migrate rmf_panel js component to a new repo Signed-off-by: youliang <tan_you_liang@hotmail.com> * lint Signed-off-by: youliang <tan_you_liang@hotmail.com> Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
This is to address #92.
After discussion, since the react source code is located within
rmf_demos_panelstatic dir, it doesn't make sense to download the compiled version from the web. However, if we wish to compile the webpack locally, this will introduce a dependency tonpm(and other node modules), which is HUGE by itself.Thus a new repo is created to host the front end component of `rmf_demos_panel: open-rmf/rmf-panel-js#1
This in turn will simplify the setup process. All documentation are updated accordingly.
Run Rmf Demos
Similar steps to launch the demo world as before, instead of accessing the dashboard from a local GUI server (localhost:5000), now the user can straightaway access the link here: https://open-rmf.github.io/rmf-panel-js/ (which is hosted by github page)
Note that the
simple-api-serverthat act as the interface between rmf_core and web is still located withinrmf_demos_panel. port number is now configurable and change to8083to prevent conflict with the commonly used8080