Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LaneStates msg #41

Merged
merged 2 commits into from
May 23, 2022
Merged

Add LaneStates msg #41

merged 2 commits into from
May 23, 2022

Conversation

Yadunund
Copy link
Member

This PR adds LaneStates.msg to rmf_fleet_msgs. The purpose of this message is to bundle lanes that are closed and those that have speed limits imposed.

Initially wanted to just include ClosedLanes.msg inside LaneStates.msg but decided against it due to duplicate fleet_name fields. Open to feedback!

Signed-off-by: Yadunund yadunund@gmail.com

Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund Yadunund requested review from mxgrey and codebot May 11, 2022 15:25
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #41 (6bac89b) into main (a9196f4) will decrease coverage by 0.65%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            main      #41      +/-   ##
=========================================
- Coverage   5.85%    5.19%   -0.66%     
=========================================
  Files       1397     1416      +19     
  Lines      94320   107123   +12803     
  Branches   10006    10125     +119     
=========================================
+ Hits        5525     5570      +45     
- Misses     85099    97812   +12713     
- Partials    3696     3741      +45     
Flag Coverage Δ
tests 5.19% <ø> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/rmf_fleet_adapter/jobs/detail/impl_Planning.hpp 35.29% <0.00%> (-7.57%) ⬇️
...mf_rxcpp/include/rmf_rxcpp/detail/RxJobsDetail.hpp 50.00% <0.00%> (-4.17%) ⬇️
..._adapter/src/rmf_fleet_adapter/BroadcastClient.cpp 35.64% <0.00%> (-3.90%) ⬇️
...er/src/rmf_fleet_adapter/events/ResponsiveWait.cpp 39.20% <0.00%> (-1.60%) ⬇️
...adapter/src/rmf_fleet_adapter/phases/MoveRobot.hpp 32.43% <0.00%> (-0.91%) ⬇️
...f_fleet_adapter/agv/internal_RobotUpdateHandle.hpp 22.22% <0.00%> (-0.86%) ⬇️
...er/src/rmf_fleet_adapter/agv/RobotUpdateHandle.cpp 3.88% <0.00%> (-0.72%) ⬇️
...er/src/rmf_fleet_adapter/agv/FleetUpdateHandle.cpp 21.23% <0.00%> (-0.11%) ⬇️
...leet_adapter/src/rmf_fleet_adapter/TaskManager.cpp 12.74% <0.00%> (-0.10%) ⬇️
...ter/src/rmf_fleet_adapter/events/PerformAction.cpp 0.89% <0.00%> (-0.04%) ⬇️
... and 165 more

Copy link
Contributor

@codebot codebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yadunund Yadunund merged commit 5ec1fb1 into main May 23, 2022
@Yadunund Yadunund deleted the feature/lane_state branch May 23, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants