-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read_only_blockade adapter #110
Conversation
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
…robots Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of minor comments.
Should we also update the descriptions in the launch file to let users know of the read_only_blocade
node?
rmf_ros2/rmf_fleet_adapter/launch/fleet_adapter.launch.xml
Lines 7 to 12 in 9078eff
<arg name="control_type" description="Fleet adapter type: full_control or read_only"/> | |
<arg name="fleet_name" description="Name of the fleet that this adapter will interface with"/> | |
<!-- Note: We give a blank default to nav_graph_file because it is not required for read_only | |
mode. However it is still required for full_control mode. | |
TODO(MXG): Investigate if there is a better way to handle conditionally required arguments. --> | |
<arg name="nav_graph_file" default="" description="The file path of this fleet's navigation graph"/> |
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Great point! Added: 68b8bcd |
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Good catch! Fixed: 06c0faa |
|
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
… into test/add_margins
Signed-off-by: Michael X. Grey <grey@openrobotics.org> Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
This PR introduces the
read_only_blockade
fleet adapter which is an improved version of the oldread_only
adapter. The API for integrating withread_only_blockade
is different from the API for integrating withread_only
so I'm keeping them as separate adapters for the sake of backwards compatibility.This PR also includes a few tweaks that made performance and behavior more reliable for DP3.