Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow system integrators to specify an update listener #198

Merged
merged 5 commits into from
Apr 17, 2022

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Apr 15, 2022

As an alternative to (or in combination with) the websocket publishing of updates, this PR allows system integrators to provide their own callback to listen to update messages. System integrators can then do whatever they wish with those messages.

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #198 (867713b) into main (0a14ca8) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
  Coverage   17.85%   17.85%              
==========================================
  Files         418      836     +418     
  Lines       38308    76692   +38384     
  Branches    18332    36712   +18380     
==========================================
+ Hits         6838    13697    +6859     
- Misses      24148    48324   +24176     
- Partials     7322    14671    +7349     
Flag Coverage Δ
tests 17.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._rxcpp/RxCpp-4.1.0/Rx/v2/src/rxcpp/rx-observer.hpp
...er/src/rmf_fleet_adapter/agv/FleetUpdateHandle.cpp
...pp/RxCpp-4.1.0/Rx/v2/src/rxcpp/rx-subscription.hpp
...task_ros2/src/rmf_task_ros2/bidding/Auctioneer.cpp
...est/mock_schedule_nodes/missing_query_schedule.cpp
...adapter/src/rmf_fleet_adapter/events/GoToPlace.cpp
..._adapter/src/rmf_fleet_adapter/phases/DoorOpen.cpp
...f_fleet_adapter/agv/internal_RobotUpdateHandle.hpp
...ter/src/rmf_fleet_adapter/agv/EasyTrafficLight.cpp
..._adapter/src/rmf_fleet_adapter/agv/parse_graph.cpp
... and 1244 more

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this API, this will be so useful for upcoming integrations!

@mxgrey mxgrey merged commit 167857c into main Apr 17, 2022
@mxgrey mxgrey deleted the update_listener_api branch April 17, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants