Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a WaitUntil event and use it for ResponsiveWait #199

Merged
merged 16 commits into from
May 6, 2022
Merged

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Apr 18, 2022

This PR adds a WaitUntil event and uses it at the end of each ResponsiveWait cycle. This will relieve system integrators of the need to wait until the last waypoint's time before triggering the path_finished_callback of RobotCommandHandle::follow_new_path. Now system integrators can just trigger that callback as soon as the robot arrives at the end of the path.

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #199 (1ff4997) into main (b5557fa) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   17.83%   17.91%   +0.08%     
==========================================
  Files         418      840     +422     
  Lines       38370    77208   +38838     
  Branches    18376    36996   +18620     
==========================================
+ Hits         6842    13834    +6992     
- Misses      24203    48533   +24330     
- Partials     7325    14841    +7516     
Flag Coverage Δ
tests 17.91% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/rmf_fleet_adapter/jobs/detail/impl_Rollout.hpp
..._ros2/src/rmf_traffic_ros2/schedule/YamlLogger.cpp
...task_ros2/src/rmf_task_ros2/bidding/Auctioneer.cpp
...-4.1.0/Rx/v2/src/rxcpp/operators/rx-take_until.hpp
..._ros2/rmf_fleet_adapter/test/dump_fleet_states.cpp
...f_fleet_adapter/agv/internal_RobotUpdateHandle.hpp
...raffic_ros2/test/unit/test_ParticipantRegistry.cpp
...adapter/include/rmf_fleet_adapter/agv/Waypoint.hpp
...3n/rmf_ros2/rmf_task_ros2/src/mock_bidder/main.cpp
...eet_adapter/src/rmf_fleet_adapter/tasks/Patrol.cpp
... and 1248 more

aaronchongth
aaronchongth previously approved these changes Apr 19, 2022
Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this so quickly! LGTM

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
mxgrey added 7 commits May 5, 2022 11:40
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@mxgrey mxgrey merged commit 1b8939d into main May 6, 2022
@mxgrey mxgrey deleted the wait_until branch May 6, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants