-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for enabling/disabling Responsive Wait behavior #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 17.61% 17.70% +0.09%
==========================================
Files 209 844 +635
Lines 19351 77984 +58633
Branches 9297 37416 +28119
==========================================
+ Hits 3409 13810 +10401
- Misses 12274 49250 +36976
- Partials 3668 14924 +11256
Flags with carried forward coverage won't be shown. Click here to find out more. |
Yadunund
previously approved these changes
Sep 15, 2022
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
luca-della-vedova
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an API to toggle the responsive wait behavior on and off. It also adds a parameter to toggle the responsive wait on and off for the legacy fleet adapter. To test this, you can run the office demo from
rmf_demos
and run the following:The idle robots will disappear from the schedule which indicates that they are now completely unresponsive. Setting this parameter back to true will bring them back to the schedule and make them responsive again.