Add support for docking in lanes that have entry events #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
This PR addresses a TODO where having a
dock_name
property in a waypoint that had an entry or exit event would make the fleet adapter throw an exception.Implementation description
It turns out there is no issue with exit events, but an implementation has been added for entry events by inserting a waypoint manually, basically the following:
becomes
A and D overlap with each other. This has the effect of triggering the entry event first, then the docking event on the way to B.
This behavior is useful in cases where a system integrator wants to use docking in cases where there are entry events. A typical case is having a docking waypoint inside a lift to execute a special behavior to enter it.