Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds an option to generate unique hex strings for new task ids, fix time stamp logic #319

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Adds an option to generate unique hex strings for new task ids, fix time stamp logic #319

merged 3 commits into from
Jan 22, 2024

Conversation

aaronchongth
Copy link
Member

New feature implementation

Implemented feature

  • Allow to append random hex strings to task IDs for better uniqueness (across dispatcher restarts)
  • Fix overflow issue with timestamp approach

@aaronchongth
Adds an option to generate unique hex strings for new task ids, fix t…
8a0e3d5 
…ime stamp logic too

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth mentioned this pull request Jan 22, 2024
Merged
@aaronchongth
Use static_cast
73da20c 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth mentioned this pull request Jan 22, 2024
Closed
5 tasks
@aaronchongth
Lint
c11b157 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
mxgrey
mxgrey approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very reasonable, and it worked as expected when I tested it out.

@mxgrey mxgrey merged commit b630867 into main Jan 22, 2024
4 checks passed
@mxgrey mxgrey deleted the feature/unique-hex-string-w-taskid branch January 22, 2024 13:51
cwrx777 pushed a commit to cwrx777/rmf_ros2 that referenced this pull request Jan 25, 2024
@aaronchongth @cwrx777
Adds an option to generate unique hex strings for new task ids, fix t…
fd5a976 
…ime stamp logic (open-rmf#319)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
cwrx777 pushed a commit to cwrx777/rmf_ros2 that referenced this pull request Jan 26, 2024
@aaronchongth @cwrx777
Adds an option to generate unique hex strings for new task ids, fix t…
8f480f7 
…ime stamp logic (open-rmf#319)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Charly Wu <charlywu@medinno.com>
cwrx777 pushed a commit to cwrx777/rmf_ros2 that referenced this pull request Jan 26, 2024
@aaronchongth @cwrx777
Adds an option to generate unique hex strings for new task ids, fix t…
241718e 
…ime stamp logic (open-rmf#319)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Charly Wu <charlywu@medinno.com>
cwrx777 pushed a commit to cwrx777/rmf_ros2 that referenced this pull request Jan 26, 2024
@aaronchongth @cwrx777
Adds an option to generate unique hex strings for new task ids, fix t…
ceb5285 
…ime stamp logic (open-rmf#319)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Charly Wu <charlywu@medinno.com>
cwrx777 pushed a commit to cwrx777/rmf_ros2 that referenced this pull request Jan 26, 2024
@aaronchongth @cwrx777
Adds an option to generate unique hex strings for new task ids, fix t…
28321b6 
…ime stamp logic (open-rmf#319)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Charly Wu <charlywu@medinno.com>
cwrx777 pushed a commit to cwrx777/rmf_ros2 that referenced this pull request Jan 26, 2024
@aaronchongth @cwrx777
Adds an option to generate unique hex strings for new task ids, fix t…
e7bd7dc 
…ime stamp logic (open-rmf#319)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Charly Wu <charlywu@medinno.com>
arjo129 pushed a commit that referenced this pull request Jun 7, 2024
@aaronchongth @arjo129
Adds an option to generate unique hex strings for new task ids, fix t…
91ce68b 
…ime stamp logic (#319)

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxgrey mxgrey mxgrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaronchongth @mxgrey