Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interaction between emergency pullover and finishing task #333

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Mar 14, 2024

When an emergency pullover interrupts a finishing task, the robots that were doing the finishing task would not resume the finishing task correctly.

With this PR, finishing tasks will resume correctly after an emergency pullover is released.

Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
@mxgrey mxgrey requested a review from xiyuoh March 14, 2024 15:20
@mxgrey mxgrey self-assigned this Mar 14, 2024
xiyuoh
xiyuoh previously approved these changes Mar 19, 2024
Copy link
Member

@xiyuoh xiyuoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with a charge finishing task and it works great! The finishing task is triggered as expected.

Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
@mxgrey mxgrey merged commit b50fe7f into main Mar 19, 2024
2 of 4 checks passed
@mxgrey mxgrey deleted the fix_pullover branch March 19, 2024 15:00
arjo129 pushed a commit that referenced this pull request Jun 7, 2024
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants