Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow navigation graph lanes to be disabled #9

Closed
mxgrey opened this issue Mar 15, 2021 · 6 comments
Closed

Allow navigation graph lanes to be disabled #9

mxgrey opened this issue Mar 15, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@mxgrey
Copy link
Contributor

mxgrey commented Mar 15, 2021

Feature request

Allow lanes to be disabled

Description

There may be various reasons that the lane of a navigation graph needs to be disabled. If a corridor is needs to be closed off for maintenance, or if too many obstacles have been detected, we should be able to tell the fleet adapter to disable the lane and plan around it.

@mxgrey mxgrey added the enhancement New feature or request label Mar 15, 2021
@mxgrey mxgrey added this to Fleet Management in Research & Development Mar 15, 2021
@txlei
Copy link

txlei commented Mar 16, 2021

@mxgrey would there be a method to "enable" the lane again?

Also, it was decided that regardless of the obstacle detected, the robot would attempt to overcome it using its local planner. When it concludes its attempt as a failure, the replanning would be last resort. Hence, the robot is already on the "impassable lane". Would that implicate rmf's global planner efforts to replan?

@mxgrey
Copy link
Contributor Author

mxgrey commented Mar 16, 2021

would there be a method to "enable" the lane again?

Yes, absolutely. This feature will allow lanes to be toggled on and off.

the robot is already on the "impassable lane". Would that implicate rmf's global planner efforts to replan?

No worries, I fully intend to handle this situation. I expect this will be a common occurrence 👍

@txlei
Copy link

txlei commented Mar 19, 2021

disable the lane and plan around it.

Does this API require location of the obstacle as input? Or it assumes the obstacle is somewhere in the same direction of where the robot is heading towards. i.e. On the traffic lane, the path in front of the robot is impassable and the path behind the robot is passable.

@mxgrey
Copy link
Contributor Author

mxgrey commented Mar 19, 2021

Nope, the API will just specify which lane(s) to close down. From the planner's point of view, the only thing it means if a lane is closed is that the planner can't expand its path search down that lane.

I can put some logic into the fleet adapter that will check if the robot is currently on a lane that's being closed, and then the fleet adapter will have the robot return to the lane's entry waypoint if it is.

@txlei
Copy link

txlei commented Mar 19, 2021

That works. Thank you.

@mxgrey mxgrey moved this from Fleet/Task Management to In Progress in Research & Development Mar 24, 2021
@mxgrey mxgrey moved this from In Progress to Done in Research & Development Mar 25, 2021
@mxgrey
Copy link
Contributor Author

mxgrey commented Mar 25, 2021

Finished by #15

@mxgrey mxgrey closed this as completed Mar 25, 2021
mxgrey pushed a commit that referenced this issue Apr 22, 2021
* add api html docs and slight cleanup on readme

* change doc path to index.html

* update README

* Update shapes.cpp

* regenerate docs and fix test

* missing battery
luca-della-vedova pushed a commit that referenced this issue Jan 10, 2023
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants