Refactor and cleanup utils #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
|
Maybe we should consider merging |
gbiggs
approved these changes
Apr 5, 2021
luca-della-vedova
added a commit
that referenced
this pull request
Apr 5, 2021
* Move slotcar to rmf_robot_sim_* Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Fix namespace usage Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Refactor and cleanup utils (#6) Signed-off-by: Luca Della Vedova <luca@openrobotics.org> Co-authored-by: Luca Della Vedova <luca@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Utility libraries were not being properly linked and one of them (the one in
rmf_building_sim_common) only happened to work because the code was duplicated between header and .cpp file.Fix applied
This PR removes all the code duplication in the
utils.hppfile and links correctly the libraries throughtarget_link_libraries.The
utils.cppfile was actually in thermf_building_sim_gazebo_pluginsnamespace so it wasn't used anywhere.TODO
Figure out if we should move the utils code to a common library, a lot of functions are now duplicated between
rmf_robot_sim_commonandrmf_building_sim_common