Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making install location package specific #60

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Nov 11, 2021

Bug fix

Fixed bug

Fixes open-rmf/rmf#100.

Fix applied

Changes install location to lib/<package_name> to avoid conflicts among libraries named the same.

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #60 (a84fe36) into main (7e80608) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             main     #60      +/-   ##
=========================================
  Coverage    0.00%   0.00%              
=========================================
  Files        1062     138     -924     
  Lines      101843   12845   -88998     
=========================================
+ Misses     101843   12845   -88998     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/include/rmf_robot_sim_common/slotcar_common.hpp
...lding_sim_ignition_plugins/src/crowd_simulator.cpp
...on_plugins/src/toggle_charging/toggle_charging.cpp
...uilding_sim_gazebo_plugins/src/crowd_simulator.hpp
...uilding_sim_gazebo_plugins/src/toggle_charging.cpp
...ion/rmf_robot_sim_ignition_plugins/src/slotcar.cpp
...rmf_building_sim_common/crowd_simulator_common.hpp
...lation/rmf_building_sim_common/src/lift_common.cpp
...ation/rmf_robot_sim_common/src/ingestor_common.cpp
...ion/rmf_building_sim_ignition_plugins/src/lift.cpp
... and 1178 more

@marcoag marcoag merged commit a459690 into main Nov 12, 2021
@marcoag marcoag deleted the fix_install_conflict branch November 12, 2021 15:24
marcoag pushed a commit that referenced this pull request Dec 1, 2021
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apt binary install issue for RMF galactic
2 participants