-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignition GUI plugin to toggle floor visibility. #72
Ignition GUI plugin to toggle floor visibility. #72
Conversation
Signed-off-by: Tan Chian Fern <chianfern@openrobotics.org>
Tested on hotel demo and works as expected 👍 |
Signed-off-by: Tan Chian Fern <chianfern@openrobotics.org>
Thanks for the PR! Looking great so far. I only encountered one edge case that happens when the plugin is used to toggle a floor, then closed and reopened, from what I see:
I can see how this could be a tricky issue since you would need to preserve state across plugin object creation / destruction, I guess some solutions could be:
I'm OK with anything really, as long as there is consistent behavior between what is set in the plugin and what is visible |
Signed-off-by: Tan Chian Fern <chianfern@openrobotics.org>
Thanks for the catch! Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks!
Signed-off-by: Tan Chian Fern chianfern@openrobotics.org
toggle_floors plugin
Adds a
ignition::gui::Plugin
to toggle visibility of floors and robots.Requires rmf_traffic_editor #424. Closes #66.
Note: There's an unresolved issue with
LoadConfig()
. It reads the information in the world sdf correctly on first load, but not when the plugin is closed and reloaded.Update: Resolved, plugin information is retrieved again when reloaded.