Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes potential segfault #79

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Conversation

arjo129
Copy link
Member

@arjo129 arjo129 commented Aug 23, 2022

The fix is similar in nature to #78. Just noticed another place where we are not checking for a potential null return value. This hasn't segfaulted for me yet but theres no reason why it would not.

Signed-off-by: Arjo Chakravarty arjo@openrobotics.org

arjo129 and others added 3 commits August 23, 2022 09:11
The fix is similar in nature to #78. Just noticed another place where we are not checking for a potential null return value.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund Yadunund mentioned this pull request Aug 25, 2022
4 tasks
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #79 (1480bd7) into main (d3e0c0c) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #79   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        144     144           
  Lines      13412   13424   +12     
=====================================
- Misses     13412   13424   +12     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ation/rmf_robot_sim_common/src/readonly_common.cpp
...ion/rmf_building_sim_ignition_plugins/src/lift.cpp
...uilding_sim_gazebo_plugins/src/toggle_charging.cpp
...ation/rmf_robot_sim_common/src/readonly_common.cpp
...uilding_sim_gazebo_plugins/src/crowd_simulator.cpp
...on/include/rmf_robot_sim_common/slotcar_common.hpp
...ing_sim_gazebo_plugins/src/thumbnail_generator.cpp
...ion/rmf_building_sim_ignition_plugins/src/door.cpp
...nition_plugins/src/toggle_floors/toggle_floors.cpp
...lation/rmf_building_sim_common/src/lift_common.cpp
... and 262 more

@Yadunund Yadunund merged commit 2a16bcc into main Aug 25, 2022
@Yadunund Yadunund deleted the arjo/fix/yet_another_potential_segfault branch August 25, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants