Fixes a segfault in toggle floor plugin which causes ignition to crash when scene is not ready. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h when scene is not ready. This PR fixes a segfault I have been experiencing when loading large worlds. Often the rendering scene is not fully setup causing the` this->scene->NodeByName` to crash. This PR pushes a simple fix to skip over scenarios where the scene has not yet loaded the model. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
codebot
approved these changes
Aug 22, 2022
|
Not sure why CI is failing. The failure seems unrelated, |
arjo129
added a commit
that referenced
this pull request
Aug 23, 2022
The fix is similar in nature to #78. Just noticed another place where we are not checking for a potential null return value. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Merged
Yadunund
added a commit
that referenced
this pull request
Aug 25, 2022
* Fixes potential segfault The fix is similar in nature to #78. Just noticed another place where we are not checking for a potential null return value. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * Fix typo Signed-off-by: Yadunund <yadunund@gmail.com> Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: Luca Della Vedova <luca@openrobotics.org> Co-authored-by: Yadunund <yadunund@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a segfault I have been experiencing when loading large worlds. Often the rendering scene is not fully setup causing the
this->scene->NodeByNameto crash. This PR pushes a simple fix to skip over scenarios where the scene has not yet loaded the model.Signed-off-by: Arjo Chakravarty arjo@openrobotics.org