Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emergency stop #82

Merged
merged 6 commits into from Sep 13, 2022
Merged

Fix emergency stop #82

merged 6 commits into from Sep 13, 2022

Conversation

mxgrey
Copy link
Collaborator

@mxgrey mxgrey commented Sep 8, 2022

This PR fixes the implementation of the emergency stop. Previously there was a risk that a robot which is supposed to drive backwards will refuse to do so if there another robot in front of itself, even though there is no robot behind it in the direction that it is actually supposed to travel.

As a bonus I made some of the logging output a bit more informative and removed the time-based hold behavior which is no longer needed.

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #82 (a3934aa) into main (d9c2a90) will not change coverage.
The diff coverage is n/a.

❗ Current head a3934aa differs from pull request most recent head 3ad478b. Consider uploading reports for the commit 3ad478b to get more accurate results

@@            Coverage Diff             @@
##             main     #82       +/-   ##
==========================================
  Coverage    0.00%   0.00%               
==========================================
  Files        1368      76     -1292     
  Lines      134666    6787   -127879     
==========================================
+ Misses     134666    6787   -127879     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m_ignition_plugins/src/LightTuning/LightTuning.cpp
...ion/rmf_building_sim_ignition_plugins/src/lift.cpp
...on_plugins/src/toggle_charging/toggle_charging.cpp
...ion/rmf_building_sim_ignition_plugins/src/door.cpp
...lation/rmf_building_sim_common/src/door_common.cpp
..._sim_common/include/rmf_robot_sim_common/utils.hpp
...lding_sim_ignition_plugins/src/crowd_simulator.cpp
...tion/rmf_robot_sim_gazebo_plugins/src/readonly.cpp
...lation/rmf_building_sim_common/src/door_common.cpp
...robot_sim_gazebo_plugins/src/TeleportDispenser.cpp
... and 1418 more

mxgrey and others added 4 commits September 8, 2022 17:14
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova luca-della-vedova merged commit 5b123e6 into main Sep 13, 2022
@luca-della-vedova luca-della-vedova deleted the fix_e_stop branch September 13, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants