Fix the production of indefinite charging tasks #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
|
Note that I am not proud of the way that I implemented the fix, but any other approach would have compromised API or ABI stability. I think the current state of the API has accumulated a considerable number of design missteps that can't be fixed without a new major revision, and I'm going to save that for our next generation work. |
mxgrey
added a commit
that referenced
this pull request
Dec 12, 2023
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
mxgrey
added a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we added the
set_indefinite(bool)method to the charge task factory, it wasn't actually being used (whoops).This PR makes sure that indefinite charging tasks are produced by the factory when the user has requested it.