Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on rmf_dispenser_msgs #36

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Conversation

Yadunund
Copy link
Member

Fix #35

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #36 (d7dceb1) into main (87a7cad) will increase coverage by 0.10%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   38.80%   38.90%   +0.10%     
==========================================
  Files          27       27              
  Lines        1500     1501       +1     
  Branches      904      905       +1     
==========================================
+ Hits          582      584       +2     
+ Misses        222      221       -1     
  Partials      696      696              
Flag Coverage Δ
tests 38.90% <56.25%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rmf_task/test/unit/agv/test_TaskPlanner.cpp 24.25% <0.00%> (-0.06%) ⬇️
rmf_task/src/rmf_task/requests/Delivery.cpp 40.16% <60.00%> (+1.63%) ⬆️

Copy link
Member

@youliangtan youliangtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks cleaner after removing the dispenser_msgs, no more ros dep. Soon we can also let the task planner take account of the workcell execution wait time, cant wait for that!

@Yadunund Yadunund merged commit 8349287 into main Aug 18, 2021
@Yadunund Yadunund deleted the remove_dispenser_msgs branch August 18, 2021 08:05
@Yadunund
Copy link
Member Author

The changes in this PR make the task planner account for the waiting period at the pickup and dropoff locations 😄

@youliangtan
Copy link
Member

Ah I should hav said it clearer. The "workcell" execution time indirectly means pickup/dropoff duration. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on rmf_dispenser_msgs
2 participants