Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check crowd sim impl pointer before deref #263

Merged
merged 1 commit into from Nov 18, 2020
Merged

check crowd sim impl pointer before deref #263

merged 1 commit into from Nov 18, 2020

Conversation

codebot
Copy link
Contributor

@codebot codebot commented Nov 18, 2020

During new project creation, the crowd_sim_impl pointer will be nullptr so the automatic save during creation explodes. This one-liner makes it not explode.

Signed-off-by: Morgan Quigley morgan@osrfoundation.org

@codebot
check crowd sim impl pointer before deref
505300f 
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@codebot codebot requested a review from mxgrey November 18, 2020 08:18
@codebot codebot added the bug Something isn't working label Nov 18, 2020
mxgrey
mxgrey approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great now, thanks!

@codebot codebot merged commit 1c345e2 into master Nov 18, 2020
@codebot codebot deleted the dont_crash_on_new_project_crowdsim branch November 18, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxgrey mxgrey mxgrey approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebot @mxgrey